Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLA-1370: Fixed a bug from a previous commit for computing statistics #1910

Merged

Conversation

mdlpstsci
Copy link
Collaborator

@mdlpstsci mdlpstsci commented Nov 7, 2024

Resolves HLA-1370

Closes #

Fixed a bug associated with a previous commit when computing statistics on the illuminated portion only of the drizzled image. The computation now uses the footprint_mask which is based on the DRZ CTX image which reports the number of images which contributed to the final pixel value. If the CTX[i,j] > 0, then the pixel is illuminated.

Checklist for maintainers

  • added entry in CHANGELOG.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR

on the illuminated portion only of the drizzled image.  The computation
now uses the footprint_mask computed on the DRZ CTX image which reports
the number of images which contributed to the final pixel value.  If the
CTX > 0, then the pixel is illuminated.
@mdlpstsci mdlpstsci requested a review from s-goldman November 7, 2024 14:16
@mdlpstsci mdlpstsci self-assigned this Nov 7, 2024
@mdlpstsci mdlpstsci requested a review from a team as a code owner November 7, 2024 14:16
Copy link
Collaborator

@s-goldman s-goldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the logic works correctly now, the code looks fine.

@mdlpstsci mdlpstsci merged commit 2420032 into spacetelescope:main Nov 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants